fix(types): introduce the MapLike-type instead of using Map#25
Open
aslushnikov wants to merge 1 commit intogithub:mainfrom
Open
fix(types): introduce the MapLike-type instead of using Map#25aslushnikov wants to merge 1 commit intogithub:mainfrom
aslushnikov wants to merge 1 commit intogithub:mainfrom
Conversation
As of today, the https://github.com/isaacs/node-lru-cache cannot be used as a cache for memoization since `LRUCache` doesn't define the `Symbol.toStringTag`. This patch narrows down type requirements for cache implementations.
Contributor
import memoize from "@github/memoize";
import { LRUCache } from "lru-cache";
// const myCache = new Map<string, string>();
const myCache = new LRUCache<string, string>({ max: 2 });
const randomName = memoize(
function randomName(length: number) {
const upper = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
const lower = "abcdefghijklmnopqrstuvwxyz";
let result = "";
for (let i = 0; i < length; i++) {
result += (i === 0 ? upper : lower).charAt(
Math.floor(Math.random() * upper.length)
);
}
return result;
},
{ cache: myCache }
);
function main() {
console.log("hello", randomName(5));
console.log("Hullo", randomName(5));
console.log("Heil", randomName(5));
console.log(myCache);
}
main();works. Was it perhaps not working in late 2023? |
arelia
reviewed
Aug 21, 2024
| @@ -1,3 +1,10 @@ | |||
| type MapLike<K, V> = { | |||
There was a problem hiding this comment.
👋🏾 from Web Systems - bumping this comment #25 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today, the https://github.com/isaacs/node-lru-cache cannot be used as a cache for memoization since
LRUCachedoesn't define theSymbol.toStringTag.This patch narrows down type requirements for cache implementations.